<html>
<head><meta charset="utf-8"><title>Nagging about x.py changelog · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html">Nagging about x.py changelog</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210867623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210867623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210867623">(Sep 22 2020 at 13:14)</a>:</h4>
<p>I'm waiting for all the hate mail about <a href="https://github.com/rust-lang/rust/pull/76626">https://github.com/rust-lang/rust/pull/76626</a> lol</p>



<a name="210868192"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210868192" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210868192">(Sep 22 2020 at 13:19)</a>:</h4>
<p>I can start. If I <code>rm config.toml; ./x.py run src/tools/expand-yaml-anchors</code>, then I get the warning. Presumably that's what a brand new contributor would see, even though there aren't <em>changes</em> from their POV</p>



<a name="210869395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210869395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210869395">(Sep 22 2020 at 13:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Planning.20x.2Epy's.20future/near/210867623">said</a>:</p>
<blockquote>
<p>I'm waiting for all the hate mail about <a href="https://github.com/rust-lang/rust/pull/76626">https://github.com/rust-lang/rust/pull/76626</a> lol</p>
</blockquote>
<p>Nagging bad.</p>



<a name="210869654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210869654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210869654">(Sep 22 2020 at 13:31)</a>:</h4>
<p>Can the version stamp live in the build directory at least, and not in the config file?<br>
Can the warning with the changelog link be reported only if there are build errors + the version stamp exists + the version stamp is different from the current one?</p>



<a name="210871724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210871724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210871724">(Sep 22 2020 at 13:47)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116155">Jake Goulding</span> <a href="#narrow/stream/242791-t-infra/topic/Planning.20x.2Epy's.20future/near/210868192">said</a>:</p>
<blockquote>
<p>I can start. If I <code>rm config.toml; ./x.py run src/tools/expand-yaml-anchors</code>, then I get the warning. Presumably that's what a brand new contributor would see, even though there aren't <em>changes</em> from their POV</p>
</blockquote>
<p>that will be fixed by <a href="https://github.com/rust-lang/rust/pull/76631">https://github.com/rust-lang/rust/pull/76631</a></p>



<a name="210871928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210871928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210871928">(Sep 22 2020 at 13:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="123856">Vadim Petrochenkov</span> <a href="#narrow/stream/242791-t-infra/topic/Planning.20x.2Epy's.20future/near/210869654">said</a>:</p>
<blockquote>
<p>Can the version stamp live in the build directory at least, and not in the config file?</p>
</blockquote>
<p>Do you mean an untracked file in the build directory? That sounds reasonable, I can add it to .gitignore.</p>
<blockquote>
<p>Can the warning with the changelog link be reported only if there are build errors + the version stamp exists + the version stamp is different from the current one?</p>
</blockquote>
<p>I'm hesitant to report only if there are build errors. That wouldn't have warned for any of the changes in <a href="https://blog.rust-lang.org/inside-rust/2020/08/30/changes-to-x-py-defaults.html">https://blog.rust-lang.org/inside-rust/2020/08/30/changes-to-x-py-defaults.html</a>, which are really the motivation for this</p>



<a name="210872015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872015">(Sep 22 2020 at 13:49)</a>:</h4>
<p>oh wait did you mean <code>build/</code>? That seems unhelpful, then you'll get warned again on <code>rm -rf build</code></p>



<a name="210872224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872224">(Sep 22 2020 at 13:51)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Planning.20x.2Epy's.20future/near/210872015">said</a>:</p>
<blockquote>
<p>oh wait did you mean <code>build/</code>? That seems unhelpful, then you'll get warned again on <code>rm -rf build</code></p>
</blockquote>
<p>No, the " + the version stamp exists" part will prevent that.</p>



<a name="210872286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872286">(Sep 22 2020 at 13:51)</a>:</h4>
<p>then no one will create the version stamp, so they'll never get warned :/</p>



<a name="210872370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872370">(Sep 22 2020 at 13:52)</a>:</h4>
<p>the point of this is that x.py <em>does</em> change under your nose and there <em>isn't</em> a way to opt-out, so the best we can do is warn about it</p>



<a name="210872396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872396">(Sep 22 2020 at 13:52)</a>:</h4>
<p>Successfull build will automatically create the stamp, in the build directory.</p>



<a name="210872423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872423">(Sep 22 2020 at 13:52)</a>:</h4>
<p>ah ok, that sounds useful</p>



<a name="210872459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872459">(Sep 22 2020 at 13:52)</a>:</h4>
<p>hm so that seems perhaps like something users will easily miss though?</p>



<a name="210872493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210872493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210872493">(Sep 22 2020 at 13:53)</a>:</h4>
<p>it does seem reasonable to put it in the build directory vs config.toml though</p>



<a name="210873247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210873247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210873247">(Sep 22 2020 at 13:58)</a>:</h4>
<p>how does this show a message to distro maintainers?</p>



<a name="210873273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210873273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210873273">(Sep 22 2020 at 13:58)</a>:</h4>
<p>if it stores it in <code>build/</code> and only warn if the stamp there changes, it will never show a warning on a fresh clone</p>



<a name="210873354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210873354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210873354">(Sep 22 2020 at 13:59)</a>:</h4>
<p>not sure I follow</p>



<a name="210873408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210873408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210873408">(Sep 22 2020 at 13:59)</a>:</h4>
<p>build/ is just easier for us to e.g. auto-update and such</p>



<a name="210877978"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210877978" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210877978">(Sep 22 2020 at 14:30)</a>:</h4>
<p>right, but <span class="user-mention silent" data-user-id="123856">Vadim Petrochenkov</span> 's suggestion was to only warn if the file already existed</p>



<a name="210878021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210878021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210878021">(Sep 22 2020 at 14:30)</a>:</h4>
<p>so then it will never warn on a fresh build, so @infinity0 and others won't see it</p>



<a name="210878149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210878149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210878149">(Sep 22 2020 at 14:31)</a>:</h4>
<p>and if we <em>don't</em> do that and only store it in <code>build/</code> without modifying it automatically, then it warns again on <code>rm -rf build/</code> which is unhelpful</p>



<a name="210879378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210879378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210879378">(Sep 22 2020 at 14:39)</a>:</h4>
<p><em>I</em> do <code>rm -rf build/</code>, but I thought the recommendation was <code>x.py clean</code>?</p>



<a name="210879537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210879537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210879537">(Sep 22 2020 at 14:40)</a>:</h4>
<p>sure, but it still shouldn't warn again</p>



<a name="210880388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210880388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210880388">(Sep 22 2020 at 14:46)</a>:</h4>
<p>But wouldn't <code>x.py clean</code> leave the file, like it leaves the llvm directory?</p>



<a name="210880512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Nagging%20about%20x.py%20changelog/near/210880512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Nagging.20about.20x.2Epy.20changelog.html#210880512">(Sep 22 2020 at 14:47)</a>:</h4>
<p>I could make sure <code>x.py clean</code> did that, yes. But I still think that having <code>rm -rf build</code> warn is worse than having the stamp in <code>config.toml</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>